Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: split QualificationDetailsController.cs #479

Merged

Conversation

ThomasWhittington
Copy link
Collaborator

@ThomasWhittington ThomasWhittington commented Dec 3, 2024

Description

Moved as much logic as I can out of controllers and into services. Also split the details controller into details and search. Routes remain the same

How Has This Been Tested?

All relevant unit tests have been reworked for the new system. All e2e tests remain unchanges and still work as they used to

Checklist:

  • My code follows the standards used within this project
  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests (Unit, E2E) that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ThomasWhittington ThomasWhittington changed the title chore: split QualificationDetailsController.cs into a new Qualificati… chore: split QualificationDetailsController.cs Dec 3, 2024
@ThomasWhittington ThomasWhittington changed the base branch from main to release/02-Dec-24-R1 December 4, 2024 11:55
@ThomasWhittington ThomasWhittington marked this pull request as ready for review December 9, 2024 18:14
Copy link
Contributor

github-actions bot commented Jan 7, 2025

Code Coverage

Package Line Rate Branch Rate Health
Dfe.EarlyYearsQualification.Mock 100% 98%
Dfe.EarlyYearsQualification.Content 98% 90%
Summary 99% (2106 / 2133) 92% (289 / 314)

Minimum allowed line rate is 90%

@ThomasWhittington ThomasWhittington merged commit 12c549e into release/02-Dec-24-R1 Jan 7, 2025
3 checks passed
@ThomasWhittington ThomasWhittington deleted the chore/qualification-details-refactor branch January 7, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants